aweisberg commented on code in PR #101:
URL: https://github.com/apache/cassandra-accord/pull/101#discussion_r1663191671
##########
accord-core/src/main/java/accord/coordinate/Recover.java:
##########
@@ -262,7 +261,12 @@ private void recover()
case Applied:
case PreApplied:
{
- withCommittedDeps(executeAt, stableDeps -> {
+ withCommittedDeps(executeAt, (stableDeps, failure) -> {
+ if (failure != null)
+ {
+ // TODO (review): This case we don't pass a
callback to persist, is that intentional?
Review Comment:
I reworked this to have them all pass a wrapped exception to the agent.
##########
accord-core/src/main/java/accord/coordinate/RecoverWithRoute.java:
##########
@@ -211,9 +211,15 @@ else if (!known.definition.isOrWasKnown())
if (known.executeAt.isDecidedAndKnownToExecute() &&
known.deps.hasDecidedDeps() && known.outcome == Apply)
{
Deps deps = full.stableDeps.reconstitute(route());
- node.withEpoch(full.executeAt.epoch(), () -> {
+ node.withEpoch(full.executeAt.epoch(), (ignored,
withEpochFailure) -> {
+ if (withEpochFailure != null)
+ {
+ // TODO (review): We already ignore persist errors
here by not providing a callback to persist
Review Comment:
I reworked this to have them all pass a wrapped exception to the agent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
