belliottsmith commented on code in PR #106:
URL: https://github.com/apache/cassandra-accord/pull/106#discussion_r1693372714
##########
accord-core/src/main/java/accord/local/RedundantBefore.java:
##########
@@ -109,6 +109,8 @@ public Entry(Range range, long startEpoch, long endEpoch,
@Nonnull TxnId locally
this.shardAppliedOrInvalidatedBefore =
shardAppliedOrInvalidatedBefore;
this.bootstrappedAt = bootstrappedAt;
this.staleUntilAtLeast = staleUntilAtLeast;
+
Invariants.checkArgument(locallyAppliedOrInvalidatedBefore.equals(TxnId.NONE)
|| locallyAppliedOrInvalidatedBefore.domain().isRange());
Review Comment:
We shouldn’t be inserting them into this map is all - this is a map for GC
and we don’t want that to be at the point/key level
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
