dcapwell commented on code in PR #106:
URL: https://github.com/apache/cassandra-accord/pull/106#discussion_r1693653308
##########
accord-core/src/test/java/accord/impl/PrefixedIntHashKey.java:
##########
@@ -310,6 +310,10 @@ public int compareTo(@Nonnull RoutableKey that)
int rightInt = that instanceof Sentinel ? (((Sentinel)
that).isMin ? -1 : 1) : 0;
rc = Integer.compare(leftInt, rightInt);
}
+ else if (!(this instanceof PrefixedIntRoutingKey) && (!(that
instanceof PrefixedIntRoutingKey)))
Review Comment:
`Key` isn't a common super class, it's the final top level class. We have 3
top level types: `Key | Hash | Sentinel`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
