belliottsmith commented on code in PR #106:
URL: https://github.com/apache/cassandra-accord/pull/106#discussion_r1697613368
##########
accord-core/src/main/java/accord/local/Command.java:
##########
@@ -1138,7 +1081,6 @@ private Committed(CommonAttributes common, SaveStatus
status, Timestamp executeA
super(common, status, promised, executeAt, accepted);
this.waitingOn = waitingOn;
Invariants.checkState(common.route().kind().isFullRoute(),
"Expected a full route but given %s", common.route().kind());
- if (status.hasBeen(Stable)) Invariants.checkState(waitingOn ==
WaitingOn.EMPTY ||
(waitingOn.txnIds.equals(common.partialDeps().rangeDeps.txnIds()) &&
waitingOn.keys.equals(common.partialDeps().keyDeps.keys())), "Deps do not
match; expected (%s, %s) == (%s, %s)", waitingOn.keys, waitingOn.txnIds,
common.partialDeps().keyDeps.keys(), common.partialDeps().rangeDeps.txnIds());
Review Comment:
It didn't seem as useful as it was given how we load, and also that we don't
set it to EMPTY anymore, but in retrospect I will reinstate an updated version
with suitable paranoia gating.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
