dcapwell commented on code in PR #106:
URL: https://github.com/apache/cassandra-accord/pull/106#discussion_r1693654828
##########
accord-core/src/main/java/accord/local/Command.java:
##########
@@ -1138,7 +1081,6 @@ private Committed(CommonAttributes common, SaveStatus
status, Timestamp executeA
super(common, status, promised, executeAt, accepted);
this.waitingOn = waitingOn;
Invariants.checkState(common.route().kind().isFullRoute(),
"Expected a full route but given %s", common.route().kind());
- if (status.hasBeen(Stable)) Invariants.checkState(waitingOn ==
WaitingOn.EMPTY ||
(waitingOn.txnIds.equals(common.partialDeps().rangeDeps.txnIds()) &&
waitingOn.keys.equals(common.partialDeps().keyDeps.keys())), "Deps do not
match; expected (%s, %s) == (%s, %s)", waitingOn.keys, waitingOn.txnIds,
common.partialDeps().keyDeps.keys(), common.partialDeps().rangeDeps.txnIds());
Review Comment:
why was this check removed?
##########
accord-core/src/main/java/accord/utils/btree/BTree.java:
##########
@@ -501,6 +501,23 @@ else if (c < 0)
}
}
+ public static <Compare, Existing extends Compare, Insert extends Compare>
Object[] updateExisting(Object[] toUpdate,
Review Comment:
style
##########
accord-core/src/main/java/accord/utils/SimpleBitSet.java:
##########
@@ -419,6 +419,19 @@ private <P1, P2, P3, P4> void reverseForEach(int index,
long mask, P1 p1, P2 p2,
}
}
+ public void intersect(SimpleBitSet with)
Review Comment:
this method doesn't do anything... as long as `this.size == with.size` we
spend time computing things, but we don't actually do anything with what we
compute.
IntelliJ also says this is dead code, can we remove?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
