belliottsmith commented on code in PR #106:
URL: https://github.com/apache/cassandra-accord/pull/106#discussion_r1697615068
##########
accord-core/src/test/java/accord/impl/basic/DelayedCommandStores.java:
##########
@@ -163,6 +166,9 @@ public DelayedCommandStore(int id, NodeTimeService time,
Agent agent, DataStore
@Override
public void validateRead(Command current)
{
+ if (!Invariants.testParanoia(LINEAR, LINEAR, HIGH))
Review Comment:
I don't think it should be enabled by default, as we don't *usually* touch
this and it has a significant performance penalty. I think we should introduce
a lighter-weight version that doesn't perform the intrusive diffs but still
optionally loads from the journal that would also catch the majority of
problems, that can be on by default.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
