aweisberg commented on code in PR #3395:
URL: https://github.com/apache/cassandra/pull/3395#discussion_r1707516941
##########
src/java/org/apache/cassandra/service/accord/AccordService.java:
##########
@@ -592,12 +715,9 @@ public TopologyManager topology()
}
catch (TimeoutException e)
{
+ // TODO (review): This is j.u.c timeout so maybe this should mark?
Review Comment:
It's double marking the metric, because `coordinateAsync` in the callback
also marks the timeout. It seems like we need to be consistent about
responsibility for firing the timeout. Should it be `getTxnResult` or
`coordinateAsync`?
I am thinking the highest level is where we should do it because that is
where we are blocking and Accord might fail to fire the timeout?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
