aweisberg commented on code in PR #3395:
URL: https://github.com/apache/cassandra/pull/3395#discussion_r1707974710


##########
src/java/org/apache/cassandra/service/consensus/TransactionalMode.java:
##########
@@ -112,6 +112,10 @@ public ConsistencyLevel 
commitCLForStrategy(ConsistencyLevel consistencyLevel)
         return consistencyLevel;
     }
 
+    // TODO (required): This won't work for migration directly from none to 
full because there is no safe system to read from

Review Comment:
   Yeah that is what it would need to do and it's what I implemented later when 
splitting into two phases. `TransactionalMode` takes in a `ClusterMetadata` and 
`Token` and makes a determination about `ConsistencyLevel` that is specific to 
whether the range is the `Token` is in has completed migration so it runs the 
appropriate interop `ConsistencyLevel` until it is no longer needed. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to