aweisberg commented on code in PR #3395:
URL: https://github.com/apache/cassandra/pull/3395#discussion_r1707541119
##########
src/java/org/apache/cassandra/service/accord/AccordService.java:
##########
@@ -592,12 +715,9 @@ public TopologyManager topology()
}
catch (TimeoutException e)
{
+ // TODO (review): This is j.u.c timeout so maybe this should mark?
Review Comment:
An now I remember why this was tricky, the issue is how I did CAS where it
maps the future and never calls `getTxnResult`. I need to fix that so it goes
through the `getTxnResult` code so their share this error handling and metrics.
##########
src/java/org/apache/cassandra/service/accord/AccordService.java:
##########
@@ -592,12 +715,9 @@ public TopologyManager topology()
}
catch (TimeoutException e)
{
+ // TODO (review): This is j.u.c timeout so maybe this should mark?
Review Comment:
An now I remember why this was tricky, the issue is how I did CAS where it
maps the future and never calls `getTxnResult`. I need to fix that so it goes
through the `getTxnResult` code so they share this error handling and metrics.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
