ekaterinadimitrova2 commented on code in PR #3444:
URL: https://github.com/apache/cassandra/pull/3444#discussion_r1717275792
##########
src/java/org/apache/cassandra/cql3/restrictions/SimpleRestriction.java:
##########
@@ -217,7 +219,11 @@ public boolean isSupportedBy(Index index)
@Override
public List<ClusteringElements> values(QueryOptions options)
{
- assert operator == Operator.EQ || operator == Operator.IN || operator
== Operator.ANN;
+ assert operator == Operator.EQ ||
+ operator == Operator.IN ||
+ operator == Operator.ANN ||
+ operator == Operator.NEQ ||
+ operator == Operator.NOT_IN;
Review Comment:
Indeed, you are right. I see the confusion came from IN and EQ where we use:
```
@Override
public boolean requiresFilteringOrIndexingFor(ColumnMetadata.Kind columnKind)
{
return columnKind.isPrimaryKeyKind();
}
```
Also for a moment, I thought about some special case with UNSET VALUE we
may have here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
