dcapwell commented on code in PR #3486:
URL: https://github.com/apache/cassandra/pull/3486#discussion_r1725441739


##########
test/unit/accord/utils/Gen.java:
##########
@@ -87,6 +89,22 @@ default Gen<A> filter(Predicate<A> fn)
         };
     }
 
+    default Gen<A> filter(int maxAttempts, A defaultValue, Predicate<A> fn)

Review Comment:
   a lot of changes to these classes are not *needed* for this patch, but my 
thinking is to try to make in-sync with accord so the next rebase isn't a pain



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to