dcapwell commented on code in PR #3486:
URL: https://github.com/apache/cassandra/pull/3486#discussion_r1725449041
##########
test/unit/accord/utils/Gens.java:
##########
@@ -433,16 +735,7 @@ public Gen<T[]> ofSizeBetween(int minSize, int maxSize) {
int size = sizeGen.nextInt(r);
T[] list = (T[]) Array.newInstance(type, size);
for (int i = 0; i < size; i++)
- {
- try
- {
- list[i] = fn.next(r);
- }
- catch (IgnoreGenResult e)
- {
- return Arrays.copyOf(list, i);
- }
- }
+ list[i] = fn.next(r);
Review Comment:
I don't know when/why this was removed and looking at the `List` version
this looks like a bug... we don't hit this case often with arrays which is prob
why we didn't notice...
I plan to create a patch for cep-15-accord + accord to keep them in-sync
with this PR... ill try to mixup in both places soon
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
