dcapwell commented on code in PR #3486:
URL: https://github.com/apache/cassandra/pull/3486#discussion_r1725748959
##########
src/java/org/apache/cassandra/tcm/AbstractLocalProcessor.java:
##########
@@ -56,7 +56,7 @@ public final Commit.Result commit(Entry.Id entryId,
Transformation transform, fi
{
ClusterMetadata previous = log.waitForHighestConsecutive();
if
(!previous.fullCMSMembers().contains(FBUtilities.getBroadcastAddressAndPort()))
- throw new IllegalStateException("Node is not a member of CMS
anymore");
+ throw new IllegalStateException("Node " +
FBUtilities.getBroadcastAddressAndPort() + " is not a member of CMS anymore in
" + previous.epoch + "; members=" + previous.fullCMSMembers());
Review Comment:
this was super flakey and added a ignore filter so the test won't fail if
this is seen anymore (assuming its safe... think it is)...
I saw a history where node1 starts a snapshot, node1 looses its CMS
membership (nodes 2/3/4 are now the members), then this check blows up...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
