dcapwell commented on code in PR #3486: URL: https://github.com/apache/cassandra/pull/3486#discussion_r1733301079
########## test/distributed/org/apache/cassandra/fuzz/topology/HarryTopologyMixupTest.java: ########## @@ -0,0 +1,160 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.cassandra.fuzz.topology; + +import java.util.function.BiFunction; +import java.util.function.Consumer; +import java.util.function.Function; + +import javax.annotation.Nullable; + +import accord.utils.Gen; +import accord.utils.Property; +import accord.utils.Property.Command; +import accord.utils.Property.PreCheckResult; +import accord.utils.Property.SimpleCommand; +import accord.utils.RandomSource; +import org.apache.cassandra.distributed.Cluster; +import org.apache.cassandra.distributed.api.IInstanceConfig; +import org.apache.cassandra.harry.HarryHelper; +import org.apache.cassandra.harry.dsl.ReplayingHistoryBuilder; +import org.apache.cassandra.harry.sut.SystemUnderTest; +import org.apache.cassandra.harry.sut.TokenPlacementModel; +import org.apache.cassandra.harry.sut.injvm.InJvmSut; + +import static org.apache.cassandra.distributed.shared.ClusterUtils.waitForCMSToQuiesce; + +public class HarryTopologyMixupTest extends TopologyMixupTestBase<HarryTopologyMixupTest.Spec> +{ + @Override + protected Gen<State<Spec>> stateGen() + { + return HarryState::new; + } + + @Override + protected void preCheck(Property.StatefulBuilder builder) + { + // if a failing seed is detected, populate here + // Example: builder.withSeed(42L); + } + + @Override + protected void destroyState(State<Spec> state, @Nullable Throwable cause) + { + if (cause != null) return; + if (((HarryState) state).numInserts > 0) + { + // do one last read just to make sure we validate the data... + var harry = state.schemaSpec.harry; + harry.validateAll(harry.quiescentLocalChecker()); + } + } + + private static Spec createSchemaSpec(RandomSource rs, Cluster cluster) + { + ReplayingHistoryBuilder harry = HarryHelper.dataGen(rs.nextLong(), + new InJvmSut(cluster), + new TokenPlacementModel.SimpleReplicationFactor(3), + SystemUnderTest.ConsistencyLevel.ALL); + cluster.schemaChange(String.format("CREATE KEYSPACE %s WITH replication = {'class': 'SimpleStrategy', 'replication_factor' : 3};", HarryHelper.KEYSPACE)); + var schema = harry.schema(); + cluster.schemaChange(schema.compile().cql()); + waitForCMSToQuiesce(cluster, cluster.get(1)); + return new Spec(harry); + } + + private static BiFunction<RandomSource, State<Spec>, Command<State<Spec>, Void, ?>> cqlOperations(Spec spec) + { + class HarryCommand extends SimpleCommand<State<Spec>> + { + HarryCommand(Function<State<Spec>, String> name, Consumer<State<Spec>> fn) + { + super(name, fn); + } + + @Override + public PreCheckResult checkPreconditions(State<Spec> state) + { + int clusterSize = state.topologyHistory.up().length; + return clusterSize >= 3 ? PreCheckResult.Ok : PreCheckResult.Ignore; + } + } + Command<State<Spec>, Void, ?> insert = new HarryCommand(state -> "Harry Insert" + state.commandNamePostfix(), state -> { + spec.harry.insert(); + ((HarryState) state).numInserts++; + }); + Command<State<Spec>, Void, ?> validateAll = new HarryCommand(state -> "Harry Validate All" + state.commandNamePostfix(), state -> { + spec.harry.validateAll(spec.harry.quiescentLocalChecker()); + ((HarryState) state).numInserts = 0; + }); + return (rs, state) -> { + HarryState harryState = (HarryState) state; + TopologyHistory history = state.topologyHistory; + // if any topology change happened, then always validate all + if (harryState.generation != history.generation()) + { + harryState.generation = history.generation(); + return validateAll; + } + if (harryState.numInserts > 500 Review Comment: > like "stateful model checker" from QT where is this? your example is harry's and the QT one Jordan worked on never merged nor really got used in the project. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
