belliottsmith commented on code in PR #113:
URL: https://github.com/apache/cassandra-accord/pull/113#discussion_r1746089195
##########
accord-core/src/main/java/accord/api/Agent.java:
##########
@@ -100,4 +108,39 @@ default EventsListener metricsEventsListener()
{
return EventsListener.NOOP;
}
+
+ /**
+ * For each shard, select a small number of replicas that should be
preferred for listening to progress updates
+ * from {@code from}. This should be 1-2 nodes that will be contacted
preferentially for progress to minimise
+ * the number of messages we exchange. These nodes should be picked in a
fashion so that there is a chain
+ * connecting all replicas of a shard together, e.g. in a ring picking the
replicas directly behind you in the ring.
+ */
+ default Topologies selectPreferred(Node.Id from, Topologies to) { return
to; }
Review Comment:
I will add one to the C* integration, though it is an optional optimisation
we can add later
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
