belliottsmith commented on code in PR #113:
URL: https://github.com/apache/cassandra-accord/pull/113#discussion_r1746062740
##########
accord-core/src/main/java/accord/local/cfk/Pruning.java:
##########
@@ -225,9 +239,9 @@ static CommandsForKey pruneBefore(CommandsForKey cfk,
TxnInfo newPrunedBefore, i
case TRANSITIVELY_KNOWN:
case PREACCEPTED_OR_ACCEPTED_INVALIDATE:
case ACCEPTED:
- if (minUndecidedById < 0 && managesExecution(txn))
- minUndecidedById = retainCount;
++retainCount;
+ if (i == minUndecidedById)
Review Comment:
we're checking equality now, so we're only looking for an exact match that
was already known to be the `minUndecidedById` (and hence had the test already
performed)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
