belliottsmith commented on code in PR #113:
URL: https://github.com/apache/cassandra-accord/pull/113#discussion_r1746070005
##########
accord-core/src/main/java/accord/messages/CalculateDeps.java:
##########
@@ -36,44 +36,44 @@
import static accord.messages.PreAccept.calculatePartialDeps;
import static accord.primitives.EpochSupplier.constant;
-public class GetDeps extends TxnRequest.WithUnsynced<PartialDeps>
+public class CalculateDeps extends TxnRequest.WithUnsynced<PartialDeps>
{
public static final class SerializationSupport
{
- public static GetDeps create(TxnId txnId, PartialRoute<?> scope, long
waitForEpoch, long minEpoch, boolean doNotComputeProgressKey, Seekables<?, ?>
keys, Timestamp executeAt)
+ public static CalculateDeps create(TxnId txnId, Route<?> scope, long
waitForEpoch, long minEpoch, Seekables<?, ?> keys, Timestamp executeAt)
{
- return new GetDeps(txnId, scope, waitForEpoch, minEpoch,
doNotComputeProgressKey, keys, executeAt);
+ return new CalculateDeps(txnId, scope, waitForEpoch, minEpoch,
keys, executeAt);
}
}
public final Seekables<?, ?> keys;
public final Timestamp executeAt;
- public GetDeps(Id to, Topologies topologies, FullRoute<?> route, TxnId
txnId, Seekables<?, ?> keys, Timestamp executeAt)
+ public CalculateDeps(Id to, Topologies topologies, FullRoute<?> route,
TxnId txnId, Seekables<?, ?> keys, Timestamp executeAt)
{
super(to, topologies, txnId, route);
this.keys = keys.intersecting(scope);
this.executeAt = executeAt;
}
- protected GetDeps(TxnId txnId, PartialRoute<?> scope, long waitForEpoch,
long minEpoch, boolean doNotComputeProgressKey, Seekables<?, ?> keys, Timestamp
executeAt)
+ protected CalculateDeps(TxnId txnId, Route<?> scope, long waitForEpoch,
long minEpoch, Seekables<?, ?> keys, Timestamp executeAt)
{
- super(txnId, scope, waitForEpoch, minEpoch, doNotComputeProgressKey);
+ super(txnId, scope, waitForEpoch, minEpoch);
this.keys = keys;
this.executeAt = executeAt;
}
@Override
public void process()
{
- node.mapReduceConsumeLocal(this, minUnsyncedEpoch, executeAt.epoch(),
this);
+ node.mapReduceConsumeLocal(this, minEpoch, executeAt.epoch(), this);
}
@Override
public PartialDeps apply(SafeCommandStore instance)
{
- Ranges ranges = instance.ranges().allBetween(minUnsyncedEpoch,
executeAt);
- return calculatePartialDeps(instance, txnId, keys, scope,
constant(minUnsyncedEpoch), executeAt, ranges);
+ Ranges ranges = instance.ranges().allBetween(minEpoch, executeAt);
Review Comment:
In some cases we use this when we aren't just considering unsynced epochs in
the past, so it seemed less misleading to simply call it a minEpoch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
