smiklosovic commented on code in PR #3412: URL: https://github.com/apache/cassandra/pull/3412#discussion_r1765779032
########## test/unit/org/apache/cassandra/db/virtual/StorageOperationsTableCleanupTest.java: ########## @@ -0,0 +1,133 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.cassandra.db.virtual; + +import org.junit.After; + +import org.apache.cassandra.db.CleanupTest; +import org.apache.cassandra.db.compaction.CompactionManager; +import org.apache.cassandra.db.compaction.OperationType; +import org.apache.cassandra.schema.SchemaConstants; +import org.apache.cassandra.tools.ToolRunner; + +import static org.apache.cassandra.tools.ToolRunner.invokeNodetool; + +public class StorageOperationsTableCleanupTest extends CleanupTest Review Comment: This is an interesting way of doing it. Honestly I have never encountered something like this. I understand what you are trying to do here but I think this is not a good practice. Each test should be just standalone or extend some hierarchy of abstract class(es). Overriding the test methods is really strange to my taste. I do not know yet how to approach this differently, looking into `CleanupTest`, there is a lot of private methods which might be `protected` and each test method would be repeated here and you would add the bits you just added after you called test methods from `CleanupTest` into them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
