Mmuzaf commented on code in PR #3412:
URL: https://github.com/apache/cassandra/pull/3412#discussion_r1767072739
##########
src/java/org/apache/cassandra/db/compaction/CompactionManager.java:
##########
@@ -174,6 +183,12 @@ public class CompactionManager implements
CompactionManagerMBean, ICompactionMan
final Multiset<ColumnFamilyStore> compactingCF =
ConcurrentHashMultiset.create();
public final ActiveCompactions active = new ActiveCompactions();
+ private final Cache<TimeUUID, OperationInfo> operations =
CacheBuilder.newBuilder()
Review Comment:
I tend to use "space-bound" only in favor of both options altogether. Both
of them are configurable via the system settings, so it should be no problem to
customize them for any type of deployment. Based on the SLA we have and my
previous experience it should be fine having 7d and 300 entries, but of course
we can update these numbers.
The insert order is timestamp-UUID, which is a primary key for the virtual
table we are trying to add, so with a default query it will be sorted
naturally. I've checked the caching API and haven't found any sorting
capabilities, but I don't think it should matter for such a small table.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
