smiklosovic commented on code in PR #3412:
URL: https://github.com/apache/cassandra/pull/3412#discussion_r1765793830
##########
src/java/org/apache/cassandra/db/compaction/CompactionManager.java:
##########
@@ -174,6 +183,12 @@ public class CompactionManager implements
CompactionManagerMBean, ICompactionMan
final Multiset<ColumnFamilyStore> compactingCF =
ConcurrentHashMultiset.create();
public final ActiveCompactions active = new ActiveCompactions();
+ private final Cache<TimeUUID, OperationInfo> operations =
CacheBuilder.newBuilder()
Review Comment:
I wanted to say that his should be "space-bound" instead of "time-bound" but
I noticed that you actually did both which is great. If somebody goes crazy and
they cleanup like mad then without the limit on size this would grow and grow
without any control.
I would just like to know based on what you did it like 7 days and 300
entries. Is this empirical based on your workload? I think revisiting the
decision about the figures here would be nice.
Also, does the cache preserve any insertion order? If you do
operations.toMap(), do I get entries without any particular order in the
virtual table? I would like them to be ordered the same way every single time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
