dcapwell commented on code in PR #103:
URL: https://github.com/apache/cassandra-accord/pull/103#discussion_r1777747078
##########
accord-core/src/test/java/accord/topology/TopologyManagerTest.java:
##########
@@ -146,48 +146,33 @@ void syncCompleteFor()
TopologyManager service = tracker();
Assertions.assertFalse(service.getEpochStateUnsafe(2).syncComplete());
+ // shards to nodes: [[1, 2, 3], [4, 5, 6]]
+ // by syncing node 1/2 shard 1 has reached quorum, but not shard 2
service.onEpochSyncComplete(id(1), 2);
service.onEpochSyncComplete(id(2), 2);
Assertions.assertFalse(service.getEpochStateUnsafe(2).syncComplete());
Assertions.assertTrue(service.getEpochStateUnsafe(2).syncCompleteFor(keys(150).toParticipants()));
Assertions.assertFalse(service.getEpochStateUnsafe(2).syncCompleteFor(keys(250).toParticipants()));
}
- /**
- * Epochs should only report being synced if every preceding epoch is also
reporting synced
- */
@Test
- void existingEpochPendingSync()
Review Comment:
deleted the test as its no longer relevant... making sure that a new epoch
doesn't resolve the past is no longer true... new epochs resolve the previous
ones!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
