dcapwell commented on code in PR #103:
URL: https://github.com/apache/cassandra-accord/pull/103#discussion_r1680104804
##########
accord-core/src/main/java/accord/local/Bootstrap.java:
##########
@@ -140,6 +140,8 @@ void start(SafeCommandStore safeStore0)
.flatMap(syncPoint -> node.withEpoch(epoch, () ->
store.submit(contextFor(localSyncId, syncPoint.waitFor.keyDeps.keys(),
KeyHistory.COMMANDS), safeStore1 -> {
if (valid.isEmpty()) // we've lost ownership of the range
return AsyncResults.success(Ranges.EMPTY);
+ if (!syncPoint.waitFor.isEmpty() &&
!node.topology().hasEpoch(syncPoint.waitFor.minTxnId().epoch()))
+ throw Invariants.illegalState("Deps has a txn %s that
contains an unknown epoch; min=%d, max=%d", syncPoint.waitFor.minTxnId(),
node.topology().minEpoch(), node.topology().current().epoch());
Review Comment:
we could... the end result will be the same. I prefer throws but its not a
strong preference... in this lambda
`Commands.createBootstrapCompleteMarkerTransaction` and
`safeStore1.registerHistoricalTransactions` both have similar checks as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
