aweisberg commented on code in PR #3575:
URL: https://github.com/apache/cassandra/pull/3575#discussion_r1800170931
##########
src/java/org/apache/cassandra/db/SinglePartitionReadCommand.java:
##########
@@ -1266,6 +1272,32 @@ public boolean isRangeRequest()
return false;
}
+ /*
+ * The execution method does not need to perform reconciliation so the
read command
+ * should execute in a mannager suited to not needing reconciliation. Such
as when
+ * executing transactionally at a single replica and doing an index scan
where the index
+ * scan should not return extra rows and expect post filtering at the
coordinator.
+ */
+ public SinglePartitionReadCommand withoutReconciliation()
+ {
+ if (indexQueryPlan() == null)
+ return this;
Review Comment:
Not 100% following, so there are more cases where we want to not have
reconciliation, and the right check is `rowFilter().isEmpty()`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
