aweisberg commented on code in PR #3575:
URL: https://github.com/apache/cassandra/pull/3575#discussion_r1800175289
##########
src/java/org/apache/cassandra/service/reads/DataResolver.java:
##########
@@ -278,6 +277,10 @@ private PartitionIterator
resolveWithReplicaFilteringProtection(E replicas, Repa
private UnaryOperator<PartitionIterator>
preCountFilterForReplicaFilteringProtection()
{
+ // Key columns are immutable and should never need to participate in
replica filtering
+ if (!command.rowFilter().hasNonKeyExpressions())
+ return results -> results;
Review Comment:
I think you sent me this fix at one point. That should be fine right since
one we rebase the history will look correct? Do we not need the fix that this
does?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
