maedhroz commented on code in PR #3575:
URL: https://github.com/apache/cassandra/pull/3575#discussion_r1800279031


##########
src/java/org/apache/cassandra/service/accord/txn/TxnNamedRead.java:
##########
@@ -129,6 +129,8 @@ public AsyncChain<Data> read(Timestamp executeAt)
         // this simply looks like the transaction witnessed TTL'd data and the 
data then expired
         // immediately after the transaction executed, and this simplifies 
things a great deal
         int nowInSeconds = (int) 
TimeUnit.MICROSECONDS.toSeconds(executeAt.hlc());
+        if (consistencyLevel == null || consistencyLevel == 
ConsistencyLevel.ONE)

Review Comment:
   `ONE`, `LOCAL_ONE`, `NODE_LOCAL` would all be cases where strict filtering 
should happen, but it looks like only `ONE` is in 
`SUPPORTED_READ_CONSISTENCY_LEVELS`. I think we're good.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org

Reply via email to