smiklosovic commented on code in PR #3605:
URL: https://github.com/apache/cassandra/pull/3605#discussion_r1808248209
##########
src/java/org/apache/cassandra/cql3/QueryProcessor.java:
##########
@@ -149,6 +149,7 @@ public void preloadPreparedStatements()
clientState.setKeyspace(keyspace);
Prepared prepared = parseAndPrepare(query, clientState, false);
+ prepared.cacheEntrySize = measureCacheEntrySize(id, prepared);
Review Comment:
@bereng what about putting `measureCacheEntrySize` into `prepareAndParse`?
That method would be renamed to `measureSize` or similar. Are there any cases
when we want to prepare and parse and _not_ have it measured? I think that by
the act of preparing and parsing, it should be all measured already so we do
not need to deal with it anymore. We most probably do not need to measure it
again in `storePreparedStatement`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
