bereng commented on code in PR #3605:
URL: https://github.com/apache/cassandra/pull/3605#discussion_r1808333287
##########
src/java/org/apache/cassandra/cql3/QueryProcessor.java:
##########
@@ -149,6 +149,7 @@ public void preloadPreparedStatements()
clientState.setKeyspace(keyspace);
Prepared prepared = parseAndPrepare(query, clientState, false);
+ prepared.cacheEntrySize = measureCacheEntrySize(id, prepared);
Review Comment:
Yes I share your concern, I thought about that as well. But I decided I
didn't want to burden pstmnts with the extra sizing in cases where it might not
be needed. I couldn't come up with any concrete examples but any customer apps,
side projects, other usages of code, some pstmnts generator stress tool, we
don't know what happens in C* forks, etc would be some. Wdyt?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
