worryg0d commented on code in PR #1822:
URL:
https://github.com/apache/cassandra-gocql-driver/pull/1822#discussion_r1814662301
##########
compressor.go:
##########
@@ -32,6 +32,7 @@ type Compressor interface {
Name() string
Encode(data []byte) ([]byte, error)
Decode(data []byte) ([]byte, error)
+ DecodeSized(data []byte, size uint32) ([]byte, error)
Review Comment:
Could you please look at
[this](https://github.com/worryg0d/gocql/commit/53c721ff91de86f7f02f16eeeefc4a15a290ad22)?
I tried to implement this append-like API, but I'm unsure if I should
implement the `AppendCompressed` and `AppendDecompressed` methods for our
snappy wrapper...
> I used the name Compress and Decompress instead of Encode / Decode because
it felt more natural to me but I'm fine with keeping Encode and Decode. Same
for WithLength/WithSize
I like your variants. If nobody has anything against then I'll use them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
