joao-r-reis commented on code in PR #1822:
URL:
https://github.com/apache/cassandra-gocql-driver/pull/1822#discussion_r1816932092
##########
frame.go:
##########
@@ -1060,6 +1068,10 @@ func (f *framer) parseResultMetadata() resultMetadata {
meta.pagingState = copyBytes(f.readBytes())
}
+ if meta.flags&flagMetaDataChanged == flagMetaDataChanged {
+ meta.newMetadataID = copyBytes(f.readBytes())
Review Comment:
we should only check this flag if protoversion is `> 4`. Also the result
metadata id is a `[short bytes]` not `[bytes]` (see how it is being parsed in
the `PREPARED` response and the v5 spec)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
