joao-r-reis commented on code in PR #1822:
URL: 
https://github.com/apache/cassandra-gocql-driver/pull/1822#discussion_r1814727099


##########
compressor.go:
##########
@@ -32,6 +32,7 @@ type Compressor interface {
        Name() string
        Encode(data []byte) ([]byte, error)
        Decode(data []byte) ([]byte, error)
+       DecodeSized(data []byte, size uint32) ([]byte, error)

Review Comment:
   > I'm unsure if I should implement the AppendCompressed and 
AppendDecompressed methods for our snappy wrapper...
   
   I think it's fine to make them panic since protocol v5 doesn't support 
snappy anyway.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to