tengu-alt commented on PR #1764: URL: https://github.com/apache/cassandra-gocql-driver/pull/1764#issuecomment-2449748952
> @tengu-alt we should also add a new `Batch()` function and deprecate the existing `NewBatch` (basically a "soft" rename of `NewBatch()` -> `Batch()` without breaking users) and deprecate `Session.ExecuteBatch`. > > `NewBatch` and `ExecuteBatch` can then be removed in 3.0 so that users have more than enough time to transition to the new names. @joao-r-reis I do not clearly understand. The `NewBatch()` function is already marked as `deprecated` and `session.NewBatch` is recommended to use instead. Also I can't name the function same as struct (Batch) because the `Batch` is already declared as struct. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For additional commands, e-mail: pr-h...@cassandra.apache.org
