worryg0d commented on code in PR #1764:
URL:
https://github.com/apache/cassandra-gocql-driver/pull/1764#discussion_r1829156711
##########
session.go:
##########
@@ -731,6 +731,11 @@ func (b *Batch) execute(ctx context.Context, conn *Conn)
*Iter {
return conn.executeBatch(ctx, b)
}
+func (b *Batch) Exec() error {
+ iter := b.session.executeBatch(b)
+ return iter.Close()
+}
Review Comment:
I think you should add a doc here because it is meant to be used by users.
Maybe use the same description as for `Batch.NewBatch()`.
Also, add a doc for `Session.Batch()` too.
##########
session.go:
##########
@@ -731,6 +731,11 @@ func (b *Batch) execute(ctx context.Context, conn *Conn)
*Iter {
return conn.executeBatch(ctx, b)
}
+func (b *Batch) Exec() error {
+ iter := b.session.executeBatch(b)
+ return iter.Close()
+}
Review Comment:
I think you should add a doc here because it is meant to be used by users.
Maybe use the same description as for `Session.NewBatch()`.
Also, add a doc for `Session.Batch()` too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
