tengu-alt commented on PR #1764: URL: https://github.com/apache/cassandra-gocql-driver/pull/1764#issuecomment-2451529384
> `Session.NewBatch()` should be deprecated now, global `NewBatch()` can be removed since it was deprecated already and `Session.Batch()` should be added to replace `Session.NewBatch()` (keep the same functionality). > > `Session.Batch()` does not have a conflict with the type `Batch`, you can have both (in fact this already exists with `Query()`) > > The original issue mentions the rename `Session.NewBatch()` to `Session.Batch()` already, my only additional suggestion here is to keep and deprecate `Session.NewBatch()` for now AND add the new `Session.Batch()`. I see, thank you. Done, also I've changed the `Session.NewBatch()` usage in .doc and tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For additional commands, e-mail: pr-h...@cassandra.apache.org
