dcapwell commented on code in PR #3656:
URL: https://github.com/apache/cassandra/pull/3656#discussion_r1828421677
##########
src/java/org/apache/cassandra/service/accord/AccordFastPath.java:
##########
@@ -194,7 +203,7 @@ public AccordFastPath withNodeStatusSince(Node.Id node,
Status status, long upda
}
if (!canUpdateNodeTo(current, status, updateTimeMillis,
updateDelayMillis))
- throw new InvalidRequestException(String.format("cannot transition
%s to %s at %s", node, status, updateTimeMillis));
+ throw new InvalidRequestException(String.format("cannot transition
%s to %s at %s; current %s", node, status, updateTimeMillis, current));
Review Comment:
kept seeing this but missing the "why" was missing. This didn't cause test
failures, but when monitoring epochs I would see failed transformations leading
me to debug them... just showing that we are trying to transition from status
`A` to `A` isn't allowed is enough to know "I can ignore this"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
