dcapwell commented on code in PR #3656:
URL: https://github.com/apache/cassandra/pull/3656#discussion_r1828422520


##########
src/java/org/apache/cassandra/service/accord/AccordService.java:
##########
@@ -571,6 +575,46 @@ public static List<ClusterMetadata> tcmLoadRange(long min, 
long max)
         return afterLoad;
     }
 
+    /**
+     * This method exists due to the fact that we define a retry policy for 
TCM to follow, and then TCM ignores it and does no retries...
+     */
+    private static List<ClusterMetadata> reconstruct(long min, long max)

Review Comment:
   > 5) When accord asks TCM for the epoch history, there were no retries which 
would cause stability issues during startup
   
   We define a retry policy but TCM doesn't use it, so need to do it ourselves. 
 I tried to figure out how to implement but I struggled so figured it was quick 
to do this in the caller for now...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org

Reply via email to