dcapwell commented on code in PR #3656:
URL: https://github.com/apache/cassandra/pull/3656#discussion_r1828426479
##########
src/java/org/apache/cassandra/tcm/ClusterMetadataService.java:
##########
@@ -820,6 +820,11 @@ public static class SwitchableProcessor implements
Processor
this.cmsStateSupplier = cmsStateSupplier;
}
+ public RemoteProcessor remoteProcessor()
Review Comment:
hack I plan to remove, this is only here to stay stable while Sam tries to
debug the root cause. So far it looks like FD thinks nodes are down, but when
you send the work to the other nodes they don't have this issue so they can
actually do the request... this is an issue during startup and the "proper"
solution isn't known yet... I can always remove this now and leave the tests as
flakey in this case...
##########
src/java/org/apache/cassandra/tcm/log/LogReader.java:
##########
@@ -148,7 +148,8 @@ else if (includeSnapshot)
else if (closestSnapshot.epoch.isBefore(start))
{
ImmutableList.Builder<Entry> entries = new
ImmutableList.Builder<>();
- EntryHolder entryHolder =
getEntries(closestSnapshot.epoch.nextEpoch(), end);
+ // start is exclusive, so use the closest snapshot
+ EntryHolder entryHolder = getEntries(closestSnapshot.epoch,
end);
Review Comment:
> 8) TCM’s getLogEntries method hit an edge case with snapshots where it
assumed the API was inclusive, but its exclusive; this caused a gap in epochs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
