dcapwell commented on code in PR #3656:
URL: https://github.com/apache/cassandra/pull/3656#discussion_r1828456014
##########
test/harry/main/org/apache/cassandra/harry/sut/TokenPlacementModel.java:
##########
@@ -237,6 +237,25 @@ public static List<Node> peerStateToNodes(Object[][]
resultset)
return nodes;
}
+ private static <T> T get(Object[] row, int idx, String name)
+ {
+ T t = (T) row[idx];
+ if (t == null || ((t instanceof Collection<?>) && ((Collection<?>)
t).isEmpty()))
+ throw new IncompletePeersStateException(name);
Review Comment:
mentioned this in topology mixup but this is to detect partial writes to
peers (asynchronous + partial writes = joys).... but since this logic gets used
in more places I figured safer to leave retry logic to block until the peers
update is "done"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
