dcapwell commented on code in PR #3656:
URL: https://github.com/apache/cassandra/pull/3656#discussion_r1828457314
##########
test/harry/main/org/apache/cassandra/harry/sut/injvm/InJvmSutBase.java:
##########
@@ -45,30 +46,42 @@
import org.apache.cassandra.distributed.api.IInstanceConfig;
import org.apache.cassandra.distributed.api.IMessage;
import org.apache.cassandra.distributed.api.IMessageFilters;
+import org.apache.cassandra.exceptions.RequestTimeoutException;
import org.apache.cassandra.harry.core.Configuration;
import org.apache.cassandra.harry.sut.SystemUnderTest;
+import org.apache.cassandra.utils.AssertionUtils;
+import org.assertj.core.api.Condition;
public class InJvmSutBase<NODE extends IInstance, CLUSTER extends
ICluster<NODE>> implements SystemUnderTest.FaultInjectingSut
{
private static final Logger logger =
LoggerFactory.getLogger(InJvmSutBase.class);
+ protected static final Condition<Object> TIMEOUT_CHECKER =
AssertionUtils.isInstanceof(RequestTimeoutException.class);
Review Comment:
this is a utility class we use in accord to deal with the C* exceptions we
expect, but the fact jvm-dtest throws with a different ClassLoader so type
checks don't work... this uses string name + walking the input definition to
find matches...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
