belliottsmith commented on code in PR #141:
URL: https://github.com/apache/cassandra-accord/pull/141#discussion_r1852061584
##########
accord-core/src/main/java/accord/coordinate/MaybeRecover.java:
##########
@@ -108,7 +108,7 @@ protected void onDone(Success success, Throwable fail)
if (hasMadeProgress(full))
{
if (full.durability.isDurable())
-
node.send(topologies.forEpoch(txnId.epoch()).forKey(route.homeKey()).nodes, to
-> new InformDurable(to, topologies, route, txnId, full.executeAtIfKnown(),
full.durability));
+ InformDurable.informHome(node, topologies, txnId,
route, full.executeAtIfKnown());
Review Comment:
I'll parameterise, but as mentioned in other location if unspecified the
lowest level of _durable_ durability is reasonable to assume (should perhaps
remove `Local` durability to make it clearer this is the lowest _durable_
durability).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
