belliottsmith commented on code in PR #141:
URL: https://github.com/apache/cassandra-accord/pull/141#discussion_r1852059031
##########
accord-core/src/main/java/accord/coordinate/CoordinationAdapter.java:
##########
@@ -310,14 +302,6 @@ private static class AsyncInclusiveSyncPointAdapter<U
extends Unseekable> extend
protected AsyncInclusiveSyncPointAdapter() {
super();
}
-
- @Override
- protected void addOrExecuteCallback(ExecuteBlocking<U> execute,
BiConsumer<? super SyncPoint<U>, Throwable> callback)
- {
- // If this is the async adapter then we want to invoke the
callback immediately
Review Comment:
I just properly separated the logic for async/blocking, since we shouldn't
be executing a blocking coordination act all for async, rather than simply
sharing everything except deciding in `addOrExecuteCallback` whether a/sync
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
