belliottsmith commented on code in PR #141:
URL: https://github.com/apache/cassandra-accord/pull/141#discussion_r1852057536
##########
accord-core/src/main/java/accord/coordinate/CoordinationAdapter.java:
##########
@@ -219,18 +224,17 @@ public void stabilise(Node node, Topologies any,
FullRoute<?> route, Ballot ball
@Override
public void execute(Node node, Topologies any, FullRoute<?> route,
ExecutePath path, TxnId txnId, Txn txn, Timestamp executeAt, Deps deps,
BiConsumer<? super SyncPoint<U>, Throwable> callback)
{
- Topologies all = forExecution(node, route, txnId, executeAt,
deps);
- persist(node, all, route, txnId, txn, executeAt, deps,
txn.execute(txnId, executeAt, null), txn.result(txnId, executeAt, null),
callback);
+ persist(node, null, route, txnId, txn, executeAt, deps,
txn.execute(txnId, executeAt, null), txn.result(txnId, executeAt, null),
callback);
Review Comment:
yeah, could do with some more cleaning up really but just noticed this
redundancy here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
