bbotella commented on code in PR #159:
URL: https://github.com/apache/cassandra-sidecar/pull/159#discussion_r1879026072
##########
server/src/main/java/org/apache/cassandra/sidecar/server/MainModule.java:
##########
@@ -380,6 +382,9 @@ public Router vertxRouter(Vertx vertx,
router.get(ApiEndpointsV1.GOSSIP_INFO_ROUTE)
.handler(gossipInfoHandler);
+ router.get(ApiEndpointsV1.GOSSIP_STATUS_ROUTE)
Review Comment:
It is really unfortunate having to add an entire new API when we already
have the GOSSIP_INFO_ROUTE endpoint? I even see that the GossipInfoResponse
already has a deprecated STATUS field.
I understand that we are trying to make this call more efficient by only
checking the gossip status. I wonder, could we add a filtering parameter that
helps us only executing the part of the handler that we want?
I'm thinking of a filtering pattern like:
`/api/v1/cassandra/gossip?filter=['status']` or something along those lines?
That way, and finding out why/where it was deprecated, maybe we can hijack
it to use this `storageOperations::isGossipRunning` can save us from having to
add this new API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
