skoppu22 commented on code in PR #159:
URL: https://github.com/apache/cassandra-sidecar/pull/159#discussion_r1886758978


##########
server/src/main/java/org/apache/cassandra/sidecar/server/MainModule.java:
##########
@@ -380,6 +382,9 @@ public Router vertxRouter(Vertx vertx,
         router.get(ApiEndpointsV1.GOSSIP_INFO_ROUTE)
               .handler(gossipInfoHandler);
 
+        router.get(ApiEndpointsV1.GOSSIP_STATUS_ROUTE)

Review Comment:
   As we discussed offline, we cannot infer gossip running status from STATUS 
(or STATUS_WITH_PORT) fields of gossip info. Hence we cannot use 
gossip/filter=status for gossip running status, as that filter can be mistaken 
for STATUS field of gossip info. Will continue with gossip/status endpoint 
(Other option could be gossip/runningStatus, but sounds too verbose)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to