skoppu22 commented on code in PR #159:
URL: https://github.com/apache/cassandra-sidecar/pull/159#discussion_r1880412154


##########
server/src/main/java/org/apache/cassandra/sidecar/server/MainModule.java:
##########
@@ -380,6 +382,9 @@ public Router vertxRouter(Vertx vertx,
         router.get(ApiEndpointsV1.GOSSIP_INFO_ROUTE)
               .handler(gossipInfoHandler);
 
+        router.get(ApiEndpointsV1.GOSSIP_STATUS_ROUTE)

Review Comment:
   ?filter=<> doesn't sound right in this case, as filter is usually used to 
chose some/partial fields of the output which was returned without using 
filter. In this case /gossip endpoint doesn't return 'status', so we can't 
`filter` status from it. Let me see what are alternatives and will get back to 
you.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to