frankgh commented on code in PR #172:
URL: https://github.com/apache/cassandra-sidecar/pull/172#discussion_r1910680669
##########
server/src/main/java/org/apache/cassandra/sidecar/config/ServiceConfiguration.java:
##########
@@ -92,7 +92,7 @@ default List<SocketAddress> listenSocketAddresses()
/**
* @return the maximum time skew allowed between the server and the client
*/
- int allowableSkewInMinutes();
+ SecondBoundConfiguration allowableTimeSkew();
Review Comment:
we don't have a `MinuteBoundConfiguration` class, and the reason I avoided
adding one was because it feels to me the time skew resolution is too coarse.
This resolution should have been at the second level to begin with IMO. But I
am hoping that we think about why the resolution is that coarse and maybe
reduce it to seconds.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
