frankgh commented on code in PR #172:
URL: https://github.com/apache/cassandra-sidecar/pull/172#discussion_r1910713009
##########
server/src/main/java/org/apache/cassandra/sidecar/server/MainModule.java:
##########
@@ -741,7 +741,8 @@ private static InstanceMetadata buildInstanceMetadata(Vertx
vertx,
.password(cassandraInstance.jmxRolePassword())
.enableSsl(cassandraInstance.jmxSslEnabled())
.connectionMaxRetries(jmxConfiguration.maxRetries())
-
.connectionRetryDelayMillis(jmxConfiguration.retryDelayMillis())
+ // TODO: connectionRetryDelayMillis
should be a MillisecondBoundConfiguration
Review Comment:
mostly because it'd require a refactor of the JmxClient class which lives in
a different subproject. I will give it a go though, I think it makes sense to
do the change here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
