frankgh commented on code in PR #172:
URL: https://github.com/apache/cassandra-sidecar/pull/172#discussion_r1910686957


##########
server/src/test/java/org/apache/cassandra/sidecar/TestModule.java:
##########
@@ -133,12 +135,15 @@ protected SidecarConfigurationImpl 
abstractConfig(SslConfiguration sslConfigurat
                                 .build();
         RestoreJobConfiguration restoreJobConfiguration =
         RestoreJobConfigurationImpl.builder()
-                                   
.restoreJobTablesTtlSeconds(TimeUnit.DAYS.toSeconds(14) + 1)
+                                   
.restoreJobTablesTtl(SecondBoundConfiguration.parse((TimeUnit.DAYS.toSeconds(14)
 + 1) + "s"))

Review Comment:
   yeah, I don't think there's a real use case for production code. Maybe a 
nice to have for tests, which I don't think we should take on. In any case, 
it's outside the scope of this PR



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to