Mmuzaf commented on code in PR #3752:
URL: https://github.com/apache/cassandra/pull/3752#discussion_r1913685944
##########
src/java/org/apache/cassandra/tools/nodetool/ListSnapshots.java:
##########
@@ -56,6 +71,9 @@ public void execute(NodeProbe probe)
Map<String, String> options = new HashMap<>();
options.put("no_ttl", Boolean.toString(noTTL));
options.put("include_ephemeral",
Boolean.toString(includeEphemeral));
+ options.put("keyspace", keyspace);
Review Comment:
I would only pass these parameters as options if they are not null. The
default behaviour (when we pass default null values) doesn't seem to be the
right way to work with the network.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
