chengw-netflix commented on code in PR #3752:
URL: https://github.com/apache/cassandra/pull/3752#discussion_r1908050777
##########
src/java/org/apache/cassandra/tools/nodetool/ListSnapshots.java:
##########
@@ -45,6 +45,21 @@ public class ListSnapshots extends NodeToolCmd
description = "Include ephememeral snapshots")
private boolean includeEphemeral = false;
+ @Option(title = "keyspace",
Review Comment:
iiuc, it can only filter by a single keyspace/table/snapshot? I think it
could be nice to support filtering by multiple keyspaces/tables/snapshots? We
can probably workaround by running the nodetool command multiple times but I
think it might nice to get it supported. If agreed, we can merge this PR first
and create a separate ticket for tracking that. I think it should be fairly
straightforward by modifying the
ListSnapshotsTask::getListingSnapshotsPredicate() and I am happy to make the
change.
##########
src/java/org/apache/cassandra/tools/nodetool/ListSnapshots.java:
##########
@@ -45,6 +45,21 @@ public class ListSnapshots extends NodeToolCmd
description = "Include ephememeral snapshots")
private boolean includeEphemeral = false;
+ @Option(title = "keyspace",
+ name = { "-k", "--keyspace" },
+ description = "Include snapshots of specified keyspace name")
+ private String keyspace = null;
+
+ @Option(title = "table",
+ name = { "-t", "--table" },
+ description = "Include snapshots of specified table name")
+ private String table = null;
+
+ @Option(title = "snapshot",
+ name = { "-n", "--snapshot"},
+ description = "Include snapshots of specified name")
+ private String snapshotName = null;
Review Comment:
+1 with the sorting functionality. Could be by size, time, and asc/desc,
etc.. probably we can post the JIRA link here for reference.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
