smiklosovic commented on code in PR #3752:
URL: https://github.com/apache/cassandra/pull/3752#discussion_r1908399699
##########
src/java/org/apache/cassandra/tools/nodetool/ListSnapshots.java:
##########
@@ -45,6 +45,21 @@ public class ListSnapshots extends NodeToolCmd
description = "Include ephememeral snapshots")
private boolean includeEphemeral = false;
+ @Option(title = "keyspace",
Review Comment:
yeah we can contemplate about that in the future ... Honestly I dont see a
usecase for specifying more keyspace at once. Most frequently you just want to
know snapshots of a keyspace, or a keyspace and table and it will list you all
snapshots. Or you want to see what entities where snapshotted by a specified
snapshot name. But multiple snapshot names? Well ... theoretically.
##########
src/java/org/apache/cassandra/tools/nodetool/ListSnapshots.java:
##########
@@ -45,6 +45,21 @@ public class ListSnapshots extends NodeToolCmd
description = "Include ephememeral snapshots")
private boolean includeEphemeral = false;
+ @Option(title = "keyspace",
Review Comment:
yeah we can contemplate about that in the future ... Honestly I dont see a
usecase for specifying more keyspaces at once. Most frequently you just want to
know snapshots of a keyspace, or a keyspace and table and it will list you all
snapshots. Or you want to see what entities where snapshotted by a specified
snapshot name. But multiple snapshot names? Well ... theoretically.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
